Dataset Management API Support#83
Dataset Management API Support#83PeterAustinMoore wants to merge 8 commits intoCityofSantaMonica:masterfrom
Conversation
|
General : Run FxCop on this code base (or some more modern analog) File : SODA.Tests/SodcaClientTests.cs
File : README.md
File : SODA/PipelineJob.cs
|
JoeNunnelley
left a comment
There was a problem hiding this comment.
here are some suggestions. probably the most valuable will be to run static code analysis tools and style tools on this project.
| /// <exception cref="System.ArgumentOutOfRangeException">Thrown if the specified <paramref name="resourceId"/> does not match the Socrata 4x4 pattern.</exception> | ||
| public Revision CreateRevision(string method, string resourceId, string permission = "private") | ||
| { | ||
|
|
|
@PeterAustinMoore this is a tremendous effort, thank you for submitting the PR! I haven't had the time to fully dig in and review yet, but I wanted to let you know its on our radar. One thing that would greatly help the review is if you could I can't promise when we'll get to this, but we are definitely interested in folding in the functionality. Stay tuned! |
This is my first foray into C# and .NET, so any pointers/feedback greatly appreciated. I tried to set up the building blocks based off of https://github.com/socrata/socrata-py
What it adds:
What it removes:
What it could do in the future: